Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix C# gha errors #145

Merged
merged 67 commits into from
May 14, 2024
Merged

fix C# gha errors #145

merged 67 commits into from
May 14, 2024

Conversation

Felixmil
Copy link
Collaborator

No description provided.

Felixmil and others added 30 commits April 25, 2024 09:15
@Felixmil
temporarly disable R workflows
403455a
@Felixmil
add draft workflow for building/testing/commiting binaries
011638b
@Felixmil
fix name
209b1d0
@Felixmil
fix yaml
f7407f5
@Felixmil
fix yaml (again)
004208b
@Felixmil
make linux-build job starting only after windows-build job is completed
db0f2ae
@Felixmil
modified checkout step
61eb981 
according to this: https://github.com/marketplace/actions/add-commit#working-with-prs
@rwmcintosh
try nuget
0253247
@rwmcintosh
add packagesdirectory
b9f2696
@rwmcintosh
update dotnet sdk
683e07f
@rwmcintosh
update build and test
8ee2075
@rwmcintosh
c++ cannot build using dotnet build
7539c76
@rwmcintosh
try setting path
76242ef
@rwmcintosh
try setting path
bd6f79c
@rwmcintosh
use enterprise
c474ca8
@rwmcintosh
use msbuild instead
1af038a
@rwmcintosh
not diagnostic
bbedacd
@rwmcintosh
setup R
5e1a67f
@rwmcintosh
change r path
518a9fe
@rwmcintosh
change r path
7af6d59
@rwmcintosh
log test crash
180a328
@rwmcintosh
skip failing test
8ebe2b0
@rwmcintosh
skip build when testing
b1a6cb1
@rwmcintosh
specify test projects
95d8e7b
@rwmcintosh
test release builds
62b6922
@rwmcintosh
try another assembly test
fa3ed65
@github-actions
Commit from GitHub Actions (build-c#-binaries)
11c9c1a
@rwmcintosh
try linux build
897bfe0
@rwmcintosh
Merge branch 'C#-gha-workflow' of github.com:Open-Systems-Pharmacolog…
0ba8702 
…y/RSharp into C#-gha-workflow
@rwmcintosh
try linux build
938e0bd
Felixmil and others added 20 commits May 13, 2024 11:04
@Felixmil
add quotes around building action name
bd026cf
@Felixmil
Merge branch 'C#-gha-workflow' of https://github.com/Open-Systems-Pha…
7e8f495 
…rmacology/rSharp into C#-gha-workflow
@Felixmil
fix warning
6824b4c
@Felixmil
Merge commit 'dc5a41367180e32b3377b894cbb93007ae69eea5'
c7d34e0 
#Conflicts:
#	inst/extdata/rSharp.Examples.dll
#	inst/lib/ClrFacade.dll
#	inst/lib/DynamicInterop.dll
#	inst/lib/RDotNet.dll
#	inst/lib/rSharp.dll
@Felixmil
reorganize workflow using reusables wf
ec611ad
@Felixmil
fix name
79cefab
@Felixmil
fix workflow names
7f22492
@Felixmil
remove special character
dd350fa
@Felixmil
add "needs" to run jobs sequentialy
27b0f5d
@github-actions
Commit from GitHub Actions (PR-Workflow)
b801c3c
@Felixmil
fix warnings
6b4de43
@Felixmil
add sequential execution for merge workflow
7363b38
@Felixmil
Merge branch 'C#-gha-workflow' of https://github.com/Open-Systems-Pha…
863b615 
…rmacology/rSharp into C#-gha-workflow
@github-actions
Commit from GitHub Actions (PR-Workflow)
3fa7807
@Felixmil
trigger C# builds only of some C# code changed
442139d
@Felixmil
Merge branch 'C#-gha-workflow' of https://github.com/Open-Systems-Pha…
3a39bcb 
…rmacology/rSharp into C#-gha-workflow
@Felixmil
trigger only if inst/lib/*.json file is changed (otherwise, is trigge…
b358f19 
…red by dll)
@Felixmil
Compare changes to latest commit (and not base branch)
d6b6c98
@Felixmil
Revert "Compare changes to latest commit (and not base branch)"
07f69f7 
This reverts commit d6b6c98.
@github-actions
Commit from GitHub Actions (PR-Workflow)
4034b21
@Felixmil Felixmil marked this pull request as ready for review May 14, 2024 11:10
@Felixmil Felixmil requested a review from rwmcintosh May 14, 2024 11:10
rwmcintosh
rwmcintosh reviewed May 14, 2024
View reviewed changes
.github/workflows/pr-workflow.yaml Outdated
Comment on lines 21 to 25
with:
filters: |
Csharp:
- 'inst/lib/*.json'
- 'shared/**'
Copy link
Member

@rwmcintosh rwmcintosh May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the C# workflows will run only if there's a change in one of these globs?
Part of the build process is to copy the RSharp.runtimeconfig.json from shared so I don't know if you need the json specific one. If we change the version in shared, that will change the version in inst/lib

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will rebuild C# binaries only if changes are made in the shared folder.

rwmcintosh
rwmcintosh approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@rwmcintosh rwmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the C#/C++ build triggers. I am unsure about whether it's really required. It might be.

@Felixmil
Copy link
Collaborator Author

Just one comment about the C#/C++ build triggers. I am unsure about whether it's really required. It might be.

Not entirely required but may make our lives easier when working only on R code.

@Felixmil Felixmil merged commit d98d67a into main May 14, 2024
@Felixmil Felixmil deleted the C#-gha-workflow branch May 14, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwmcintosh rwmcintosh rwmcintosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Felixmil @rwmcintosh